Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.holidays: init at 0.9.11 #71965

Merged
merged 1 commit into from Oct 25, 2019
Merged

pythonPackages.holidays: init at 0.9.11 #71965

merged 1 commit into from Oct 25, 2019

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented Oct 25, 2019 •
edited by jonringer

Motivation for this change

Add holidays Python package. Tested on a Python REPL that it worked.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
repo looks fairly active

[5 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/71965
3 package were build:
python27Packages.holidays python37Packages.holidays python38Packages.holidays

[nix-shell:/home/jon/.cache/nix-review/pr-71965]$ nix path-info -Sh ./results/python38Packages.holidays
/nix/store/87249x0h857gnkm13zfbnby77p9bgs6d-python3.8-holidays-0.9.11     99.7M

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.holidays python37Packages.holidays python38Packages.holidays

@jonringer jonringer merged commit 0109d65 into NixOS:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jluttine @jonringer