Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

franz: 5.3.3 -> 5.4.1 #71862

Merged
merged 4 commits into from
Dec 8, 2019
Merged

franz: 5.3.3 -> 5.4.1 #71862

merged 4 commits into from
Dec 8, 2019
+3 −3

Conversation

davidtwco
Copy link
Member

Motivation for this change

v5.4.0 of Franz was released.

I've included a second commit which adds myself as an additional maintainer to this package, as I've submitted a handful of PRs to update this package: #68976, #68899, #68256, #65258 and #62586.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @gnidorah

Sorry, something went wrong.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 23, 2019
ghost
ghost approved these changes Oct 24, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with nix-review pr 71862

@ghost
Copy link

ghost commented Oct 24, 2019

@davidtwco Could you please also remove me from maintainers? I see this software went on commercial rails with serious limitations in free plan. I dont care it anymore

@davidtwco
franz: remove gnidorah as maintainer
04d4ea0 
For context, see:
NixOS#71862 (comment)

Signed-off-by: David Wood <david@davidtw.co>
@davidtwco
Copy link
Member Author

@davidtwco Could you please also remove me from maintainers? I see this software went on commercial rails with serious limitations in free plan. I dont care it anymore

I've updated the PR to do this.

@ghost
Copy link

ghost commented Oct 24, 2019

@davidtwco Thank you!

@ghost ghost mentioned this pull request Oct 26, 2019
Merged
10 tasks
@davidtwco
franz: 5.4.0 -> 5.4.1

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
ff545ef
@davidtwco
Copy link
Member Author

Added a commit to upgrade to Franz 5.4.1 which has since been released.

@davidtwco davidtwco changed the title franz: 5.3.3 -> 5.4.0 franz: 5.3.3 -> 5.4.1 Oct 31, 2019
Lassulus
Lassulus approved these changes Dec 8, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review

@Lassulus Lassulus merged commit 3e64a0a into NixOS:master Dec 8, 2019
@davidtwco davidtwco deleted the franz-5.4.0 branch December 8, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidtwco @Lassulus