Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python packages set: major updates #71893

Merged
merged 432 commits into from Oct 27, 2019
Merged

Python packages set: major updates #71893

merged 432 commits into from Oct 27, 2019

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Oct 24, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh FRidh requested a review from jonringer as a code owner October 24, 2019 08:06
@FRidh
Copy link
Member Author

FRidh commented Oct 24, 2019

@jonringer up for another big PR? Some changes likely need to be reverted.

@jonringer
Copy link
Contributor

sure.... I just want to say you're a mad man

@jonringer
Copy link
Contributor

I'll spend some time after i get home from work

@FRidh
Copy link
Member Author

FRidh commented Oct 24, 2019 via email

@jonringer
Copy link
Contributor

jonringer commented Oct 24, 2019 •
edited

Do you mind if I force push to the branch, if i rebase on top of master?

EDIT: meant the base branch, which is staging...

@FRidh
Copy link
Member Author

FRidh commented Oct 25, 2019 via email

@FRidh FRidh merged commit 21177d3 into staging Oct 27, 2019
@jonringer
Copy link
Contributor

oh lol, i was about to push some.. oh well, it was like 3 packages... I'll just make a PR

@FRidh
Copy link
Member Author

FRidh commented Oct 27, 2019

Ahh, yeah, it seemed more than good enough to me. Thanks for the fixes! The changes are now in staging next, so you can open a PR against that branch if they are fixes.

@flokli
Copy link
Contributor

flokli commented Oct 31, 2019

@FRidh can we check if the bumped packages build after bumping?

At least aeb63f4 seems to reliably break the bpython build for me - I have a strong feeling we should at least check direct package breakages, and ping maintainers.

Adressed in #72371.

@FRidh
Copy link
Member Author

FRidh commented Oct 31, 2019

@flokli a best effort is made, but I am not going to check 400+ updates.

@jonringer
Copy link
Contributor

I did revert 3-4 commits which bumped frozen versions, but it takes a while to investigate, and very time consuming.

Plus each commit drop was a force push which is awkward when 2 people are using a single branch.

@mmahut mmahut mentioned this pull request Nov 1, 2019
Closed
merijnb added a commit to merijnb/nixpkgs that referenced this pull request Nov 6, 2019
@merijnb
Revert "python: jupyter_console: 5.2.0 -> 6.0.0"
7c83640 
This reverts commit dc4eb2f. It was
added in a large PR (NixOS#71893) by @FRidh, where he already predicted some of
the changes would have to be reverted. This is an obvious one, it breaks
python 2.7 compatibility, as that needs 5.x of jupyter_console.
@merijnb merijnb mentioned this pull request Nov 6, 2019
Merged
10 tasks
jonringer pushed a commit that referenced this pull request Nov 6, 2019
@merijnb
Revert "python: jupyter_console: 5.2.0 -> 6.0.0"
8b8db86 
This reverts commit dc4eb2f. It was
added in a large PR (#71893) by @FRidh, where he already predicted some of
the changes would have to be reverted. This is an obvious one, it breaks
python 2.7 compatibility, as that needs 5.x of jupyter_console.
@ahiaao
Copy link
Contributor

ahiaao commented Nov 19, 2019

@FRidh This PR incorrectly upgraded cerberus11 to version 1.3.1 instead of remaining at 1.1 like the package name suggests.

@FRidh
Copy link
Member Author

FRidh commented Nov 19, 2019

@ahiaao fixed with 9c52da0 and 34715da

@veprbl
Copy link
Member

veprbl commented Dec 23, 2019

This broke ipykernel: #76197

@Zimmi48 Zimmi48 mentioned this pull request Mar 2, 2020
Merged
@ajs124 ajs124 mentioned this pull request Mar 10, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: python 8.has: clean-up 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@FRidh @jonringer @flokli @ahiaao @veprbl @terlar