Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hedgewars: 1.0.0-beta2 -> 1.0.0 #71880

Merged
merged 1 commit into from Oct 26, 2019
Merged

hedgewars: 1.0.0-beta2 -> 1.0.0 #71880

merged 1 commit into from Oct 26, 2019

Conversation

rardiol
Copy link
Contributor

@rardiol rardiol commented Oct 24, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @kragniz @fpletz

@puppe
Copy link
Contributor

puppe commented Oct 24, 2019 •
edited

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64-linux
  • executables tested on x86_64-linux
  • all depending packages build
Possible improvements
Comments

Seems to work fine.

@puppe
Copy link
Contributor

puppe commented Oct 24, 2019

PS: I am reviewing this because the template for my pull request asked me to review other pull requests. I am new to this. I try to follow the documentation. But I don't want to give the impression that I actually know what I'm doing. 😉

@aanderse
Copy link
Member

@GrahamcOfBorg build hedgewars
@puppe how fantastic you have decided to help out! Much appreciated!

Lassulus
Lassulus approved these changes Oct 26, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, completed the basic movement tutorial

@Lassulus Lassulus merged commit 4de1877 into NixOS:master Oct 26, 2019
@jtojnar jtojnar mentioned this pull request Nov 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

@puppe puppe puppe approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rardiol @puppe @aanderse @Lassulus