Fix: move "server_id" key in API to server-level #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
force-pushed
the
move-server-id
branch
from
a8c2873
to
0a17b82
Compare
TrueBrain
added
the
changelog: breaking change
With the recent change to make server_ids independent of IPv4/IPv6, there is no longer any need to add them twice in the JSON blob. While at it remove unused fields too.
TrueBrain
force-pushed
the
move-server-id
branch
from
0a17b82
to
fed79d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent change to make server_ids independent of IPv4/IPv6,
there is no longer any need to add them twice in the JSON blob.
While at it remove unused fields too.