Fix: do not list non-public servers or servers that cannot be reached #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
force-pushed
the
fix-non-public-servers
branch
from
99b94bb
to
b734fe2
Compare
glx22
reviewed
Jul 10, 2021
Comment on lines
65
to
+66
| info["game_type"] = 1 # Public | ||
| info["connection_type"] = 2 # Direct-IP |
There was a problem hiding this comment.
With the comments there, I am fine with this for now. In the end, we need to solve #43 which would allow access to the enums defining this. Similar for the others, ofc :)
A ticket so we don't forget ;)
| @@ -124,8 +125,14 @@ async def get_server_info_for_web(self, server_id): | |||
| if info_str is None: | |||
| return None | |||
|
|
|||
| info = json.loads(info_str) | |||
| if info["game_type"] != 1: # List only GameType.PUBLIC servers. | |||
| info = json.loads(info_str) | ||
| if info["game_type"] != 1: # List only GameType.PUBLIC servers. | ||
| return None | ||
| if info["connection_type"] == 1: # Do not list ConnectionType.ISOLATED servers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.