Motivation / Problem

From coverity: Logically dead code. The indicated dead code may have performed some action; that action will never occur.

• In FreeTypeFontCache::​InternalGetGlyph(unsigned int, bool): Code can never be reached because of a logical contradiction (CWE-561)
• In PaymentRatesGraphWindow::​DrawWidget(Rect const&, int): Code can never be reached because of a logical contradiction (CWE-561)

Description

Practically in a branch of if (expr) any ternary that looks like expr ? A : B can be collapsed to A as expr is known to be true at that point. Note that in some of the cases it's more like if (!expr) with expr ? A : B, so B is chosen there.

Limitations

None.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

• The bug fix is important enough to be backported? (label: 'backport requested')
• This PR affects the save game format? (label 'savegame upgrade')
• This PR affects the GS/AI API? (label 'needs review: Script API')
  • ai_changelog.hpp, gs_changelog.hpp need updating.
  • The compatibility wrappers (compat_*.nut) need updating.
• This PR affects the NewGRF API? (label 'needs review: NewGRF')
  • newgrf_debug_data.h may need updating.
  • PR must be added to API tracker