Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ea9715d: clamping was ignored for setting values #9401

Merged
merged 1 commit into from Jun 27, 2021
Merged

Fix ea9715d: clamping was ignored for setting values #9401

merged 1 commit into from Jun 27, 2021

Conversation

SamuXarick
Copy link
Contributor

@SamuXarick SamuXarick commented Jun 26, 2021 •
edited

Motivation / Problem

screenshot#4
I can input values over the setting cap, via edit box.

Description

The clamped variable was not being used before the return value.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

glx22
glx22 approved these changes Jun 26, 2021
View reviewed changes
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the commit message, but can be fixed when merging.

@TrueBrain TrueBrain merged commit 003b6a0 into OpenTTD:master Jun 27, 2021
@SamuXarick SamuXarick deleted the settings-were-not-clamped branch July 18, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glx22 glx22 glx22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SamuXarick @glx22 @TrueBrain