Feature: Persistant rotation of numbered autosave after restart #9397
+77
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this PR and PR #9395 have conflicts. |
TrueBrain
reviewed
Jun 27, 2021
|
|
||
| std::string_view name = list.begin()->title; | ||
| std::from_chars(name.data() + this->prefix.size(), name.data() + name.size(), this->number); | ||
| } |
There was a problem hiding this comment.
This is a lot of code for in a ctor. Somehow that triggers me. But I do not have any argument for it :P So it might be bullocks. Opinions? :D
There was a problem hiding this comment.
Well, the thing has to be initialized somewhere and where else should it be, if not in the constructor? And the code seems fairly specific to this one particular problem, so it's not like refactoring anything into separate functions would have much of an advantage.
TrueBrain
reviewed
Jun 28, 2021
| static fios_getlist_callback_proc *proc = [](SaveLoadOperation fop, const std::string &file, const char *ext, char *title, const char *last) { | ||
| if (strcasecmp(ext, ".sav") == 0 && StrStartsWith(file, _prefix)) return FIOS_TYPE_FILE; | ||
| return FIOS_TYPE_INVALID; | ||
| }; |
There was a problem hiding this comment.
Suggestions to make it a bit more clear what _prefix is doing and that it is static:
static std::optional<std::string> _autosave_path;
if (!_autosave_path) _autosave_path = FioFindDirectory(AUTOSAVE_DIR);
static std::string _prefix; ///< Static as the lambda needs access to it.
/* Callback for FiosFileScanner. */
static fios_getlist_callback_proc *proc = [](SaveLoadOperation fop, const std::string &file, const char *ext, char *title, const char *last) {
if (strcasecmp(ext, ".sav") == 0 && StrStartsWith(file, _prefix)) return FIOS_TYPE_FILE;
return FIOS_TYPE_INVALID;
};
/* Prefix to check in the callback. */
_prefix = *_autosave_path + this->prefix;
? Dunno :)
It was always starting from 0 on openttd restart. Now the most recent autosave number will be used as a base to generate the next filename.
|
Function names are not the best. |
TrueBrain
approved these changes
Jul 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9396
Motivation / Problem
Autosave numbering always starts from 0 when OpenTTD is started.
Description
Retrieve the number of the most recent autosave and use it as a base for the next one.
Limitations
If more than one OpenTTD instance is running, and if they share the same
autosavedirectory, they will still overwrite each other savegames.Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.