Codechange: Remove last FOR_XXX macros #9368
Conversation
|
|
||
| private: | ||
| Tbitset bitset; | ||
| }; |
There was a problem hiding this comment.
Sadly, I have not enough knowledge to rate this part of the PR in any way :D @LordAro , mind giving this a look? Tnx!
There was a problem hiding this comment.
Dunno much either. Part of me wonders whether std::bitset might be useable somehow (though may well require a fair bit more refactoring to do so)
There was a problem hiding this comment.
Though bitset doesn't have iterators (or rather begin/end), so can it iterate over them? With my naive check you can't, and I think that was the whole point of making this iterator.
|
|
||
| private: | ||
| Tbitset bitset; | ||
| }; |
There was a problem hiding this comment.
Though bitset doesn't have iterators (or rather begin/end), so can it iterate over them? With my naive check you can't, and I think that was the whole point of making this iterator.
src/core/bitmath_func.hpp
Outdated
| * @tparam Tbitset Type of the bitset value. | ||
| */ | ||
| template <typename Tbitpos = uint, typename Tbitset = uint> | ||
| struct BitIterator { |
There was a problem hiding this comment.
The name of the class does not imply that it only considers set bits, nor that it actually returns the position and not be bit value.
|
I have no more comments. @rubidium42 : this okay with you too? PS: really cool finally these really old macros are goneeeeeeee. Nice job @glx22 :D |
Motivation / Problem
I finally finished removing
FOR_XXXmacros.(Now Intellisense is more usable)
Description
HeightMap::hwith a vector_sorted_cargo_specssub-range of standardCargoSpecLimitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.