Feature: raise the maximum NewGRF limit to 255 #9428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
force-pushed
the
increase-newgrf-limit
branch
from
f1402d5
to
40cb4c9
Compare
|
Why not just download at least 46 more NewGRFs from BaNaNaS and load them in addition to what you have already? |
rubidium42
reviewed
Jul 11, 2021
This was referenced Jul 11, 2021
Merged
TrueBrain
force-pushed
the
increase-newgrf-limit
branch
2 times, most recently
from
3de3b73
to
70fe99d
Compare
This statement was removed by accident, as it felt it could be removed. But it is used to know if the NewGRF is from the baseset folder or from the NewGRF folder.
TrueBrain
force-pushed
the
increase-newgrf-limit
branch
from
70fe99d
to
172f0d5
Compare
rubidium42
approved these changes
Jul 11, 2021
DorpsGek
pushed a commit
to OpenTTD/wiki-data
that referenced
this pull request
Sep 25, 2022
User Summary: Update: OpenTTD/OpenTTD#9428 raises NewGRF limit to 255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Every limit is one limit too many! WE WANT MORE NEWGRFS! MOAR! MMOOAAARRRR!
Description
As the Game Info now travels via TCP, we can increase the MTU limit on both sides to allow more NewGRFs. So .. I did exactly that.
I tested it with up to 209 NewGRFs .. that was all I had on disk :P
Picture to proof it!
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.