Auth API: Error when accessed prior to ServerEnv init (#11398)

SmallJoker · web-flow · commit 062fd2190e0a · 2021-06-30T20:42:26.000+02:00
diff --git a/src/script/lua_api/l_auth.cpp b/src/script/lua_api/l_auth.cpp
@@ -32,8 +32,11 @@ AuthDatabase *ModApiAuth::getAuthDb(lua_State *L)
 {
 	ServerEnvironment *server_environment =
 			dynamic_cast<ServerEnvironment *>(getEnv(L));
-	if (!server_environment)
+	if (!server_environment) {
+		luaL_error(L, "Attempt to access an auth function but the auth"
+			" system is yet not initialized. This causes bugs.");
 		return nullptr;
+	}
 	return server_environment->getAuthDatabase();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -32,8 +32,11 @@ AuthDatabase ModApiAuth::getAuthDb(lua_State L)`
`32`	`32`	`{`
`33`	`33`	`ServerEnvironment *server_environment =`
`34`	`34`	`dynamic_cast<ServerEnvironment *>(getEnv(L));`
`35`		`- if (!server_environment)`
	`35`	`+ if (!server_environment) {`
	`36`	`+ luaL_error(L, "Attempt to access an auth function but the auth"`
	`37`	`+ " system is yet not initialized. This causes bugs.");`
`36`	`38`	`return nullptr;`
	`39`	`+ }`
`37`	`40`	`return server_environment->getAuthDatabase();`
`38`	`41`	`}`
`39`	`42`