Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b33a10ef72fb
Choose a base ref
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ba45f45caede
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Jul 4, 2021

  1. Copy the full SHA
    9291650 View commit details
  2. Merge pull request #3044 from eggrobin/Meeus

    Initialize local variables in constexpr code
    eggrobin authored Jul 4, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    ba45f45 View commit details
Showing with 2 additions and 2 deletions.
  1. +2 −2 astronomy/date_time_body.hpp
4 changes: 2 additions & 2 deletions astronomy/date_time_body.hpp
Original file line number Diff line number Diff line change
@@ -173,7 +173,7 @@ inline constexpr Date Date::JD(double jd) {
// We require that jd represent midnight, so that the fractional part of jd +
// 0.5 must be 0.
constexpr double F = 0;
double A;
double A = std::numeric_limits<double>::quiet_NaN();
date_time::Calendar calendar;
if (Z < 2299'161) {
A = Z;
@@ -224,7 +224,7 @@ inline constexpr double Date::jd() const {
Y = Y - 1;
M = M + 12;
}
double B;
double B = std::numeric_limits<double>::quiet_NaN();
if (calendar_ == Calendar::Julian) {
B = 0;
} else {