Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codechange: Add CMake source group for the saveload compat tables. #9412

Merged
merged 1 commit into from Jul 4, 2021
Merged

Codechange: Add CMake source group for the saveload compat tables. #9412

merged 1 commit into from Jul 4, 2021

Conversation

michicc
Copy link
Member

@michicc michicc commented Jul 4, 2021

Motivation / Problem / Description / Limitations

Save/load source group has become a bit messy for those using Visual Studio. Putting the new compat tables into a sub-group makes it look nice again.

While at it, fix the not-working OpenGL sub-group.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@michicc
Codechange: Add CMake source group for the saveload compat tables.
2e29a18 
While at it, fix the not-working OpenGL sub-group.
@michicc michicc merged commit 10d8c17 into OpenTTD:master Jul 4, 2021
@michicc michicc deleted the pr/compat_cmake_filter branch July 4, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrueBrain TrueBrain TrueBrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michicc @TrueBrain