Codechange: Split off settings.cpp into several separate files #9414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubidium42
changed the title
|
Possible fix for VS2017 regression fail (div by 0 in AfterLoad() of intro game) in master...glx22:pr/9414 I think it was working fine before the split because everything was in the same translation unit. |
…he main settings handling logic
…gs handling logic
rubidium42
force-pushed
the
split_off_settings_table
branch
from
f035e12
to
13eb320
Compare
TrueBrain
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Potential workaround for the issue #9386. By splitting the settings table and saveload code off from the main settings file, the settings become more manageable in file size. It also provides a better separation of concerns.
Description
As the motivation already mentioned. Move the table/settings.h include from settings.cpp to a new settings_table.cpp and move the saveload specific code to saveload/settings_sl.cpp.
Review hint:
git diff --color-movedas the vast majority is just moving code around. Most work was in reducing the includes though.Limitations
This won't necessarily work forever with adding settings, though... one could then split of one of the tables into a separate cpp file, or potentially one for each of the tables. In that case settings_table.h does not need to be amended, just settings_table.cpp needs to be split.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.