Change #9188: Netsave now behaves like autosave #9395
Merged
+40
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glx22
reviewed
Jun 25, 2021
|
Note that this PR and PR #9397 have conflicts. I'll fix the review comments during the weekend. Thanks for the feedback. |
glx22
reviewed
Jun 26, 2021
|
I'm have no idea why the commit checker is failing, the commit message format looks fine to me? |
|
There's a space at the beginning of the line |
LordAro
reviewed
Jun 28, 2021
glx22
previously approved these changes
Jul 9, 2021
|
Tnx for this @Taschi120 , a fine contribution to OpenTTD :D |
|
I'll pop into the chat tomorrow and would be grateful if you could let me know in detail what exactly the "nitpicky" things are so I can do better in future. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.