Codechange: split settings.ini over several files #9421
Merged
+3,926
−3,535
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9386.
Motivation / Problem
MacOS build currently fails because our setting tables are too big. But we have been willing to split the settings table up for a while now. So a good enough reason to make that happen.
Description
I split the settings based on the group they are in the settings. There is a lot more to do here, but I wanted to keep an easy-to-review PR. If you use a coloured-diff, you will see that things are only moved:
settings.ini
is removed completely, meaning patches will have a nice conflict on it, making it more clear for patches they should be moving their settings.Future-PRs can address stuff like:
pf.reverse_at_signal
should be a pathfinding setting. And there are more similar weird ones.But, this PR is just to get that car moving. I will not be addressing these things above any time soon, so if you want to, feel free to go for it :)
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.