Change |RebuildFragmentTreeSpine| to check |PhysicalFragmentCount| #29337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 11, 2021
This patch changes |RebuildFragmentTreeSpine| to check |PhysicalFragmentCount| instead of |CanUseNewLayout|. This is consistent with the change for the subtree layout in r890653 crrev.com/c/2934743, and can handle flow threads correctly, because flow threads are not |LayoutNGMixin| even when NG block fragmentation is enabled. Bug: 965639, 829028 Change-Id: I8c9cdb16e37e67b7a0a9b0665e633d8eb200395d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2952733 Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#891728}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2952733
branch
from
0a29c28
to
73f11ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes |RebuildFragmentTreeSpine| to check
|PhysicalFragmentCount| instead of |CanUseNewLayout|.
This is consistent with the change for the subtree layout in
r890653 crrev.com/c/2934743, and can handle flow threads
correctly, because flow threads are not |LayoutNGMixin| even
when NG block fragmentation is enabled.
Bug: 965639, 829028
Change-Id: I8c9cdb16e37e67b7a0a9b0665e633d8eb200395d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2952733
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#891728}