[Gecko Bug 1715684] block port 989 and 990 for ftps-data and ftps #29343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: https://phabricator.services.mozilla.com/D117504 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1715684 gecko-commit: f58ca1eb4556f610b266f115d06a7252686d5c23 gecko-reviewers: necko-reviewers, valentin
wpt-pr-bot
approved these changes
Jun 11, 2021
3 tasks
annevk
pushed a commit
to whatwg/fetch
that referenced
this pull request
Jun 14, 2021
In light of the ALPACA Attack. Tests: web-platform-tests/wpt#29343.
webkit-commit-queue
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Jun 22, 2021
https://bugs.webkit.org/show_bug.cgi?id=226971 <rdar://problem/79287147> Reviewed by Geoffrey Garen. LayoutTests/imported/w3c: Re-sync some WPT tests from upstream d41f24f to gain test coverage from: - web-platform-tests/wpt#29343 * web-platform-tests/fetch/api/request/request-bad-port.any-expected.txt: * web-platform-tests/fetch/api/request/request-bad-port.any.js: * web-platform-tests/fetch/api/request/request-bad-port.any.worker-expected.txt: * web-platform-tests/tools/wptserve/wptserve/utils.py: (isomorphic_decode): (isomorphic_encode): (is_bad_port): (http2_compatible): * web-platform-tests/websockets/Create-blocked-port.any-expected.txt: * web-platform-tests/websockets/Create-blocked-port.any.js: * web-platform-tests/websockets/Create-blocked-port.any.worker-expected.txt: * web-platform-tests/websockets/constants.sub.js: Added. (url_has_variant): (else.url_has_flag): (url_has_flag): (IsWebSocket): (CreateWebSocketNonAbsolute): (CreateWebSocketNonWsScheme): (CreateWebSocketNonAsciiProtocol): (CreateWebSocketWithAsciiSep): (CreateWebSocketWithBlockedPort): (CreateWebSocketWithSpaceInUrl): (CreateWebSocketWithSpaceInProtocol): (CreateWebSocketWithRepeatedProtocols): (CreateWebSocketWithRepeatedProtocolsCaseInsensitive): (CreateWebSocket): Source/WTF: Prevent connecting to ports 989 & 990 as per: - whatwg/fetch#1250 * wtf/URL.cpp: (WTF::portAllowed): Canonical link: https://commits.webkit.org/239016@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
philn
pushed a commit
to philn/old-webkit
that referenced
this pull request
Jun 27, 2021
https://bugs.webkit.org/show_bug.cgi?id=226971 <rdar://problem/79287147> Reviewed by Geoffrey Garen. LayoutTests/imported/w3c: Re-sync some WPT tests from upstream d41f24fb67a2d65c to gain test coverage from: - web-platform-tests/wpt#29343 * web-platform-tests/fetch/api/request/request-bad-port.any-expected.txt: * web-platform-tests/fetch/api/request/request-bad-port.any.js: * web-platform-tests/fetch/api/request/request-bad-port.any.worker-expected.txt: * web-platform-tests/tools/wptserve/wptserve/utils.py: (isomorphic_decode): (isomorphic_encode): (is_bad_port): (http2_compatible): * web-platform-tests/websockets/Create-blocked-port.any-expected.txt: * web-platform-tests/websockets/Create-blocked-port.any.js: * web-platform-tests/websockets/Create-blocked-port.any.worker-expected.txt: * web-platform-tests/websockets/constants.sub.js: Added. (url_has_variant): (else.url_has_flag): (url_has_flag): (IsWebSocket): (CreateWebSocketNonAbsolute): (CreateWebSocketNonWsScheme): (CreateWebSocketNonAsciiProtocol): (CreateWebSocketWithAsciiSep): (CreateWebSocketWithBlockedPort): (CreateWebSocketWithSpaceInUrl): (CreateWebSocketWithSpaceInProtocol): (CreateWebSocketWithRepeatedProtocols): (CreateWebSocketWithRepeatedProtocolsCaseInsensitive): (CreateWebSocket): Source/WTF: Prevent connecting to ports 989 & 990 as per: - whatwg/fetch#1250 * wtf/URL.cpp: (WTF::portAllowed): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@279099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: https://phabricator.services.mozilla.com/D117504
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1715684
gecko-commit: f58ca1eb4556f610b266f115d06a7252686d5c23
gecko-reviewers: necko-reviewers, valentin