Use assert_approx_equals in css/css-text/i18n #29346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
fantasai,
frivoal,
kojiishi,
nox,
plinss and
r12a
|
Hey @frivoal and @xfq - @r12a mentioned that you two might be better suited to review this pull request that updated some internationalization tests of his that had been ported to wpt and changed from his original versions already. I'm new to wpt and just getting my feet wet with contributing here, so any feedback would be great. Thanks! |
laurynmm
force-pushed
the
cleanup-css-text-i18n-assertions
branch
from
0d46a38
to
5bb30aa
Compare
|
Hey @kojiishi - I've had this pull request for a clean-up issue on some i18n tests pending for a few months. I saw that you had reviewed a change to some of these files at the end of July and was wondering if you could take a look at mine. Thanks! |
Ms2ger
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25084.