Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build #3028

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Fix the build #3028

merged 1 commit into from
Jun 8, 2021

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Jun 8, 2021

Clang doesn’t want to sweep a defaulted template parameter under the rug when using the template as a template template parameter.

Drive-by change: remove an obsolete comment (the evaluator structs are really needed, if only to group Evaluate and EvaluateDerivative).

@eggrobin eggrobin added the TBR label Jun 8, 2021
@eggrobin eggrobin merged commit 38b12d6 into mockingbirdnest:master Jun 8, 2021
@eggrobin eggrobin mentioned this pull request Jun 8, 2021
template<typename Value, typename Argument, int degree, bool allow_fma>
struct HornerEvaluator;

namespace exported {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it work to close internal_polynomial_evaluators here and reopen it near line 33? That might avoid all the references to exported.

@eggrobin eggrobin mentioned this pull request Jun 8, 2021
@pleroy pleroy added LGTM and removed TBR labels Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants