Make DCHECK() about signs of w test the same condition the caller does. #29349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 11, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2956400
branch
from
43dbf04
to
81dd6ff
Compare
This changes the DCHECK() that tests that the signs of h1.w() and h2.w() are different to test exactly the same condition that the callers test. While it looks equivalent, it's different in the cases where the values are not finite, which fuzzers have (unfortunately) managed to hit, and which we should probably eventually address in a better way (given that it's undefined behavior in C++). Fixed: 1217813 Change-Id: I5b268dad8a2c2435789b00620ca0bd3cdd7bb919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2956400 Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#892200}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2956400
branch
from
81dd6ff
to
4423269
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the DCHECK() that tests that the signs of h1.w() and h2.w()
are different to test exactly the same condition that the callers test.
While it looks equivalent, it's different in the cases where the values
are not finite, which fuzzers have (unfortunately) managed to hit, and
which we should probably eventually address in a better way (given that
it's undefined behavior in C++).
Fixed: 1217813
Change-Id: I5b268dad8a2c2435789b00620ca0bd3cdd7bb919
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2956400
Commit-Queue: David Baron <dbaron@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892200}