Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebRTC] Preparation CL for making Plan B throw an exception. #29312

Merged
merged 1 commit into from Jun 11, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 9, 2021

This CL adds the code that makes constructing an RTCPeerConnection with
{sdpSemantics:"plan-b"} throw an exception, however it also adds a kill
switch for this code path that is enabled by default (meaning we will
not throw an exception).

The kill switch will be made DISABLED_BY_DEFAULT in a follow-up CL so
that in case we have to revert "making Plan B throw" we don't have to
revert evertything this CL is adding, including a web platform test and
a use counter that is likely to cause merge conflicts if reverted.

Bug: chromium:857004
Change-Id: I8452b6d883ec71ba77cc59275b038ae2cac41c73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2949808
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#891596}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

This CL adds the code that makes constructing an RTCPeerConnection with
{sdpSemantics:"plan-b"} throw an exception, however it also adds a kill
switch for this code path that is enabled by default (meaning we will
not throw an exception).

The kill switch will be made DISABLED_BY_DEFAULT in a follow-up CL so
that in case we have to revert "making Plan B throw" we don't have to
revert evertything this CL is adding, including a web platform test and
a use counter that is likely to cause merge conflicts if reverted.

Bug: chromium:857004
Change-Id: I8452b6d883ec71ba77cc59275b038ae2cac41c73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2949808
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#891596}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants