URLPattern: Support username:password@ in constructor strings.
#29311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 9, 2021
This adds support to for specifying a username and password pattern in the constructor string. While this is unlikely to be used frequently it was added to complete support for all URL components. This CL also adds a class comment for the `Parser` which was forgotten in previous CLs. Bug: 1141510 Change-Id: I984db6224b1fd36390a21c241d204573ed50d78d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2937293 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#892269}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2937293
branch
from
e034236
to
9fc2678
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to for specifying a username and password pattern in
the constructor string. While this is unlikely to be used frequently
it was added to complete support for all URL components.
This CL also adds a class comment for the
Parserwhich was forgottenin previous CLs.
Bug: 1141510
Change-Id: I984db6224b1fd36390a21c241d204573ed50d78d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2937293
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892269}