New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"CSV" from HP 'scope causes segfault #499
Comments
Moving to scopehal since this is an issue in MockOscilloscope. |
So this file provides Y values only, no timebase? Interesting. This definitely violates our input format spec but shouldn't crash. Does your scope support exporting both X and Y values? IMO the correct way to handle this file is just to report an error and tell the user to submit something well formed. |
Yes, XYValues is another option. It's also trivial to backfill the timebase
in Excel.
Reason I picked Y-only is because it takes a nontrivial amount of time to
write 400KB to a floppy disk... if that gives you an idea of the age of the
thing, haha
|
I just pushed a commit that should result in MockOscilloscope::LoadCSV() returning an error and failing, rather than segfaulting, when presented with a CSV that has only one column. From my perspective the bug (the crash) is now fixed. I intend to close this issue as soon as you confirm this fixes your problem; if you want to file a separate lower priority enhancement request for allowing import of Y-only CSV files then feel free. But I probably won't get to it any time soon as my focus is getting ready for the v0.1 release. |
There's a more detailed message on stdout. The current MockOscilloscope API only provides a success/fail status to the caller so the detailed info has to be printed elsewhere. We can clean this up in the future. |
The attached file WAV00.csv causes a segfault when importing it:
This was exported as "YValues" from my scope.
I would expect it to import with some arbitrary or user-specified timebase.
The text was updated successfully, but these errors were encountered: