Viewport propagation of forced-color-adjust #29321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 9, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2915382
branch
from
4eb2dd0
to
56c6da4
Compare
Forced-color-adjust propagates from the root to the viewport but not from the body, per the resolution in the following spec issue: w3c/csswg-drafts#6307 This CL also moves the call for Document::UpdateForcedColors() earlier in Document::Initialize() to ensure the state of forced colors mode is set early enough when determining the background-color of the viewport in forced colors mode. Bug: 1212201 Change-Id: Ib8109659083d21e1c29fc8bdae519393cb417688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2915382 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#891653}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2915382
branch
from
56c6da4
to
6d8e6db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forced-color-adjust propagates from the root to the viewport but not
from the body, per the resolution in the following spec issue:
w3c/csswg-drafts#6307
This CL also moves the call for Document::UpdateForcedColors() earlier
in Document::Initialize() to ensure the state of forced colors mode
is set early enough when determining the background-color of the
viewport in forced colors mode.
Bug: 1212201
Change-Id: Ib8109659083d21e1c29fc8bdae519393cb417688
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2915382
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#891653}