[Gecko Bug 1695509] Don't inflate overflow areas with stale positions of pushed floats that we drained but weren't able to place. #29319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at we drained but weren't able to place. Before this patch, there's an edge case where we may drain a pushed float (with a stale position), and then discover that it won't fit in the current block (so we push it and leave its position untouched), but we still inadvertently include its rect in the current block's overflow areas. This means we're feeding stale/bogus position into the overflow areas, which can make them unnecessarily huge. This patch accounts for this by only considering overflow from floats that we actually successfully placed, in ReflowPushedFloats. (Also: this patch removes a stale bit of documentation about aLineLayout being possibly-null in AddFloat. In actuality, AddFloat has a fatal assertion that mandates that this arg is non-null.) Differential Revision: https://phabricator.services.mozilla.com/D117218 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1695509 gecko-commit: 1f62700d85c2a6d2bab864d4e71586726f713457 gecko-reviewers: TYLin
wpt-pr-bot
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, there's an edge case where we may drain a pushed float (with
a stale position), and then discover that it won't fit in the current block (so
we push it and leave its position untouched), but we still inadvertently
include its rect in the current block's overflow areas. This means we're
feeding stale/bogus position into the overflow areas, which can make them
unnecessarily huge.
This patch accounts for this by only considering overflow from floats that we
actually successfully placed, in ReflowPushedFloats.
(Also: this patch removes a stale bit of documentation about aLineLayout being
possibly-null in AddFloat. In actuality, AddFloat has a fatal assertion that
mandates that this arg is non-null.)
Differential Revision: https://phabricator.services.mozilla.com/D117218
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1695509
gecko-commit: 1f62700d85c2a6d2bab864d4e71586726f713457
gecko-reviewers: TYLin