Update cached attribute values before updating children #29320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 9, 2021
When updating children of a node, first update it's cached attribute values. This prevents a situation where UpdateCachedAttributeValuesIfNeeded() would be called on the same node and potentially mark try to this->SetNeedToUpdateChildren() while |this| is already in the middle of updating children. Bug: 1208404 Change-Id: I087afb61502b629104b430b0990b504a96276a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2939686 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#891196}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2939686
branch
from
5c5e1bc
to
d4e1df8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating children of a node, first update it's cached attribute
values. This prevents a situation where
UpdateCachedAttributeValuesIfNeeded() would be called on the same
node and potentially mark try to this->SetNeedToUpdateChildren() while
|this| is already in the middle of updating children.
Bug: 1208404
Change-Id: I087afb61502b629104b430b0990b504a96276a1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2939686
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#891196}