Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[composite-bgcolor-animation] Null check on GetBackgroundColorPaintImageGenerator #29317

Merged
merged 1 commit into from Jun 10, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 9, 2021

When calling GetBackgroundColorPaintImageGenerator on local_root,
we should always performa a null-check for local_root because the
it could have been detached.

This CL does the null-check. A test case is added, exactly the case
when the local_root is detached. There is no crash with the fix.

Bug: 1215879
Change-Id: Id2401dae593da9ee960e5e5336c4d4876eb39f79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2951382
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#891421}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2951382 branch 5 times, most recently from f5154e7 to ec17ccd Compare June 10, 2021 20:08
…ageGenerator

When calling GetBackgroundColorPaintImageGenerator on local_root,
we should always performa a null-check for local_root because the
it could have been detached.

This CL does the null-check. A test case is added, exactly the case
when the local_root is detached. There is no crash with the fix.

Bug: 1215879
Change-Id: Id2401dae593da9ee960e5e5336c4d4876eb39f79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2951382
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#891421}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants