[composite-bgcolor-animation] Null check on GetBackgroundColorPaintImageGenerator #29317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling GetBackgroundColorPaintImageGenerator on local_root,
we should always performa a null-check for local_root because the
it could have been detached.
This CL does the null-check. A test case is added, exactly the case
when the local_root is detached. There is no crash with the fix.
Bug: 1215879
Change-Id: Id2401dae593da9ee960e5e5336c4d4876eb39f79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2951382
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#891421}