[Gecko Bug 1340422] Part 2: Map SVG d attribute to CSS. #29318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We parse the attribute and store it into CSS. We have tests already in wpt, svg/path/property/*, but we cannot pass them for now because we don't convert the relative commands into absolute commands. Those will be fixed in Bug 1489392 once the spec issue is resolved. Differential Revision: https://phabricator.services.mozilla.com/D81238 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1340422 gecko-commit: 44fd66676b8c18258e2e8fd25e499abcd8d32c2e gecko-reviewers: emilio
We have to calculate markers from style. Differential Revision: https://phabricator.services.mozilla.com/D115567 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1340422 gecko-commit: 22a2ccbad39cb399dc532d723d3e0dfe83a28194 gecko-reviewers: emilio
When using a mpath elememt which linked to a external path element, we use GetDistancesFromOriginToEndsOfVisibleSegments() to do a quick check if we really need to build the path (note: see SVGMotionSMILAnimationFunction::RebuildPathAndVerticesFromMpathElem), so we have to get the d property value from style in this function. Differential Revision: https://phabricator.services.mozilla.com/D116920 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1340422 gecko-commit: 4ee3b8eb9c61e048455b80a665da60cff9bc46dc gecko-reviewers: emilio
wpt-pr-bot
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We parse the attribute and store it into CSS. We have tests already in
wpt, svg/path/property/*, but we cannot pass them for now because we
don't convert the relative commands into absolute commands. Those will
be fixed in Bug 1489392 once the spec issue is resolved.
Differential Revision: https://phabricator.services.mozilla.com/D81238
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1340422
gecko-commit: 44fd66676b8c18258e2e8fd25e499abcd8d32c2e
gecko-reviewers: emilio