Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a predicate to check if a vessel is in a state that allows collapsing its trajectory #3032

Merged
merged 5 commits into from
Jun 13, 2021

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Jun 12, 2021

#2400 for vessels.

return false;
}
// Not collapsible if any part is not piled up (not even sure when that can
// happen).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should try to understand what is going in our own code, instead of treating it like KSP?
This should either be removed or be a CHECK; not being piled up is something transient when building pile ups, and we should definitely not be considering collapsibility when the pile ups are being determined.

}
}
// Not collapsible if this vessel is not in a pile-up (e.g., because it has no
// part).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be a CHECK.

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Jun 13, 2021
@pleroy pleroy merged commit b7c99e1 into mockingbirdnest:Entwurf Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants