New test for summary element as list item #29341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
jdm,
jgraham and
zqzhang
|
I'm also BTW renaming the original |
foolip
approved these changes
Jun 12, 2021
foolip
reviewed
Jun 12, 2021
| <title>CSS Test: summary with 'display: list-item' and flex children</title> | ||
| <link rel="author" title="Cameron McCormack" href="mailto:"> | ||
| <link rel="author" title="Sergio Villar Senin" href="mailto:svillar@igalia.com"> | ||
| <link rel="match" href="summary-display-list-item-002-ref.html"> |
There was a problem hiding this comment.
The lint is failing because of this.
There was a problem hiding this comment.
Copy&paste classical
| <link rel="author" title="Cameron McCormack" href="mailto:"> | ||
| <link rel="author" title="Sergio Villar Senin" href="mailto:svillar@igalia.com"> | ||
| <link rel="match" href="summary-display-list-item-002-ref.html"> | ||
| <link rel="help" href="https://html.spec.whatwg.org/multipage/rendering.html#the-details-and-summary-elements"> |
There was a problem hiding this comment.
I'd drop this and only link the spec in the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch that fixed
summary-display-list-item.htmlin WebKit was not completely correct and caused some regressions when the children of the summary where flex boxes.Adding a new test to verify that we don't regress on that.