move WebCryptoAPI to any.js #29276
Merged
move WebCryptoAPI to any.js #29276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
lucacasonato
force-pushed
the
crypto_any_js
branch
2 times, most recently
from
fb31abc
to
a968033
Compare
lucacasonato
force-pushed
the
crypto_any_js
branch
from
a968033
to
fbb79b7
Compare
lucacasonato
commented
Jun 8, 2021
Comment on lines
+270
to
+274
| promise_test(function() { | ||
| return Promise.all(all_promises) | ||
| .then(function() {done();}) | ||
| .catch(function() {done();}) | ||
| }, "setup"); |
There was a problem hiding this comment.
.any.worker.js tests automatically call done(). This is used to prevent the test suite from preemptively exiting before these promises have resolved.
Ms2ger
approved these changes
Jun 11, 2021
lucacasonato
force-pushed
the
crypto_any_js
branch
from
068512f
to
102f5a2
Compare
|
Please hold on merging. Some of these tests look to be flaky now. https://github.com/web-platform-tests/wpt/pull/29276/checks?check_run_id=2801619886. I am concerned it is related to the top level promise_test change. Wan't to investigate this real quick. |
|
Ok investigated, and seems these tests were previously already flaky: https://crbug.com/1045472. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to #27714 that doesn't break the worker tests.
I split the PR into 5 commits, each changing one of the subfolders of the
WebCryptoAPI folder. Other commits are minor fixes.
I did not change any indentation to make reviewing easier.