New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: [Actions] msys2/MinGW CI #8698
Conversation
Will compiling both 32-bit and 64-bit give us much extra info, or would one of them be enough for 99% of the good test? Doing just one could make sure CI run time doesn't get too long (applies to MSVC 2017 as well). |
Sometimes 32-bit fails while 64-bit passes. It was the case here, I needed 3 extra commits to build 32-bit. |
Wow, takes 13 minutes to run a MingW build .. what is taking so long for this target? Anyway, still more warnings to fix before we can merge this: https://github.com/OpenTTD/OpenTTD/actions/runs/582953728 :) |
I've never been able to work out how to fix the format & function-cast warnings. I suspect the best solution is just to disable them |
Yeah I tried many things for these warnings, but nothing worked. |
The warning on |
But it's defined properly and it's the only place we get a warning. |
Otherwise maybe you can PR the fixes for mingw from this PR, so we can at least accept that? Adding CI targets that generate warnings isn't that nice, especially as we are currently completely clear of any :) So I guess that would take some more effort to fix/change .. but that doesn't mean we shouldn't already accept the fixes that do work :D |
Is it just me, or is the caching not really working? Every run it takes 90s to setup MSYS2, despite it saying it loaded it from cache. Bit odd, I think? |
Motivation / Problem
Sometime we inadvertently break compilation with MinGW, and it can be unnoticed for a long time (until me or @LordAro happen to try to build with MinGW).
Description
I added MinGW to the CI build (for 32bit and 64bit).
Limitations
32bit currently fail, but it's not caused by this PR ;)Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.