Fix #9353: [Script] Garbage collecting on priority queues could crash the game #9356
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d crash the game
glx22
approved these changes
Jun 12, 2021
rubidium42
added
the
backport requested
TrueBrain
removed
the
backport requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Fixes #9353.
Description
The desctructor of ScriptPriorityQueue depends on ActiveInstance being in scope. For the garbage collection this was not the case, so add it to the garbage collection too just like for the game loop and others.
Limitations
None
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.