Expose WritableStreamDefaultController #29331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 10, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2951849
branch
from
45c57db
to
e6a6cb8
Compare
WritableStreamDefaultController was not exposed on the global object. This is not compliant with the current version of the standard. Expose it. Skipping the Blink intents process as this is a trivial change to expose an unusable constructor for spec alignment. Sent PSA: https://groups.google.com/a/chromium.org/g/blink-dev/c/wSXMiDJEsMo/m/jpqH7JjZAgAJ BUG=626703,1217982 Change-Id: I459c65cd369cdf9266d012a16750bbd05612b5ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2951849 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#899054}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2951849
branch
from
e6a6cb8
to
c0c0ec6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WritableStreamDefaultController was not exposed on the global object.
This is not compliant with the current version of the standard.
Expose it.
Skipping the Blink intents process as this is a trivial change to
expose an unusable constructor for spec alignment. Sent PSA:
https://groups.google.com/a/chromium.org/g/blink-dev/c/wSXMiDJEsMo/m/jpqH7JjZAgAJ
BUG=626703,1217982
Change-Id: I459c65cd369cdf9266d012a16750bbd05612b5ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2951849
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#899054}