Add: adhere the autosave_on_exit setting for Null videodriver #9343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't use the save at exit setting Line 817 in 12de256 |
TrueBrain
changed the title
TrueBrain
force-pushed
the
script-game-exit
branch
from
dbb782d
to
1d32a18
Compare
Completely forgot about that setting, yes, that works too :) Still needs a minor change ;) Nice, tnx :) |
TrueBrain
force-pushed
the
script-game-exit
branch
from
1d32a18
to
b50f864
Compare
glx22
reviewed
Jun 9, 2021
This is especially useful for automated-testing, to make a save when the game quits while using "-vnull:ticks=N".
TrueBrain
force-pushed
the
script-game-exit
branch
from
b50f864
to
326650f
Compare
rubidium42
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Our scripting stuff is rarely useful, but I now had a use, it wasn't supplying.
For automated testing, I want to load an (old) savegame, run for a few ticks, and save&exit, so I could compare it with later results.
But .. there is no way to do this "run for a few ticks, and save&exit" currently. I could see two possible solutions:
autosave_on_exitalso works for the null driver.Description
I went with 3), as 2) felt weird and dirty. 1) would be ideal, but is a lot more work.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.