Change: allow pause/unpause console command in single player too #9342
Conversation
src/console_cmds.cpp
Outdated
| @@ -160,6 +160,26 @@ DEF_CONSOLE_HOOK(ConHookNoNetwork) | |||
| return CHR_ALLOW; | |||
| } | |||
|
|
|||
| /** | |||
| * Check whether we are in singleplayer mode or are the server. | |||
There was a problem hiding this comment.
The name of the hook and content of the comment do not match with the implementation. It does not check whether its the server or not in network, it also checks for being in the menu.
I don't really have an useful alternative name for the hook though, unless making it super explicit like "ConHookServerOrSinglePlayerOrEditor".
There was a problem hiding this comment.
Been fiddling with this, but basically I think there is no right answer.
Updated the comment to better reflect reality, but as far as the function-name goes .. I think this name is already confusing enough, adding more letters to it doesn't help :) So yeah, I also don't have any useful alternatives, so lets go with this :)
There was a problem hiding this comment.
Nevermind, found a clean solution :)
TrueBrain
force-pushed
the
pause-in-singleplayer-is-fine
branch
4 times, most recently
from
dce34b3
to
21547f2
Compare
TrueBrain
force-pushed
the
pause-in-singleplayer-is-fine
branch
from
21547f2
to
70ce4ee
Compare
Motivation / Problem
For some weird reason,
pause/unpauseconsole command only works in network games. I couldn't think of a single reason for that to make sense.Mainly I needed this to ensure games are unpaused after game-start for automated testing. Now in
game_start.scrI can dounpause, and I am sure the game is not paused. Sweet.Description
Fixed the weird limitation.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.