Block fragmentation support in |PostLayout| #29283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 8, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2945009
branch
from
bb3e398
to
489b444
Compare
This patch changes |NGPhysicalBoxFragment::PostLayout| and |CloneWithPostLayoutFragments| to support the block fragmentation. Column boxes can't support |PostLayout| due to its different behaviors than other fragments. Instead, the logic is added to the |NGPhysicalBoxFragment| copy constructor which is called from |CloneWithPostLayoutFragments|. Bug: 829028, 965639 Change-Id: I4f304d811512de4543bd68e4bad97c3107ad7785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2945009 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#891155}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2945009
branch
from
489b444
to
e84a49a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes |NGPhysicalBoxFragment::PostLayout| and
|CloneWithPostLayoutFragments| to support the block
fragmentation.
Column boxes can't support |PostLayout| due to its different
behaviors than other fragments. Instead, the logic is added to
the |NGPhysicalBoxFragment| copy constructor which is called
from |CloneWithPostLayoutFragments|.
Bug: 829028, 965639
Change-Id: I4f304d811512de4543bd68e4bad97c3107ad7785
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2945009
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#891155}