[Gecko Bug 1716171] Make inert-retargeting-iframe.tentative.html more robust. #29355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes two problems: 1. an auto-positioned relative pos box may fall on a fractional pixel position. This breaks the test since it uses positionMove(), which throws if its params aren't integers: https://searchfox.org/mozilla-central/rev/0c7c41109902cb8967ec3ef2c0ddb326701cfbee/remote/marionette/action.js#743-745,750-752 2. appending text (with ::after) when a click occurs made the text too wide to fit on one line and thus made these boxes have a larger height which caused them to get in the way of the intended target of the click. Differential Revision: https://phabricator.services.mozilla.com/D117590 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1716171 gecko-commit: 1503a303a138ef34b15dd99dbe5adf5317b56d47 gecko-reviewers: emilio
wpt-pr-bot
approved these changes
Jun 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes two problems:
fractional pixel position. This breaks the test since it
uses positionMove(), which throws if its params aren't
integers:
https://searchfox.org/mozilla-central/rev/0c7c41109902cb8967ec3ef2c0ddb326701cfbee/remote/marionette/action.js#743-745,750-752
the text too wide to fit on one line and thus made these
boxes have a larger height which caused them to get in
the way of the intended target of the click.
Differential Revision: https://phabricator.services.mozilla.com/D117590
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1716171
gecko-commit: 1503a303a138ef34b15dd99dbe5adf5317b56d47
gecko-reviewers: emilio