Revert "[BreakoutBox] Replace MSTP::is_pending_pull_ with a counter" #29351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7a1512f2784fe0b3c68aa7a45b89aea6b38bf025. Reason for revert: crbug.com/1219040 Original change's description: > [BreakoutBox] Replace MSTP::is_pending_pull_ with a counter > > |is_pending_pull_| was used to make sure that frames were made available > to the stream only if there was a pending pull request. > > However, if multiple pull requests are issued and then no more pull > requests arrive, some of the corresponding read requests will remain > unsettled when |is_pending_pull_| becomes false. > > This CL fixes this by replacing the boolean |is_pending_pull_| with a > counter. > > Bug: 1218120 > Change-Id: I0ffc038a73a6cd1d387dc17e9c21f2c62fc50613 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2950171 > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> > Cr-Commit-Position: refs/heads/master@{#891735} Bug: 1218120 Change-Id: Ieabc569525b9da16cfd16234ed93ac7169769942 No-Presubmit: true No-Tree-Checks: true No-Try: true
wpt-pr-bot
approved these changes
Jun 11, 2021
|
Close this PR because the Chromium CL has been abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7a1512f2784fe0b3c68aa7a45b89aea6b38bf025.
Reason for revert: crbug.com/1219040
Original change's description:
Bug: 1218120
Change-Id: Ieabc569525b9da16cfd16234ed93ac7169769942
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/2957106
WPT-Export-Revision: 0a30fe38c6f64e1933f7512be601f76ced05a525