[Gecko Bug 1711479] Add the extended (two-value) font-size-adjust syntax to various WPT tests. #29253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 7, 2021
…ests. Differential Revision: https://phabricator.services.mozilla.com/D116280 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1711479 gecko-commit: 46b6ee998a7ffd2b5d90257262afb125b5658f70 gecko-reviewers: emilio
…talled font lookup. The test here used a face with `src: local(Arial);`, while the reference file used `font-family: Arial, sans-serif`; but these may not reliably result in the same behavior. The `@font-face` rule looks up a specific *face*, and if that face is not found, the test will fall back to the browser's default font; but the reference might get a *different* result if, for example, a fontconfig alias/substitution rule is present that maps Arial to a different sans-serif than the browser's default. So instead of trying to use a local font lookup to provide the metrics contrast with Ahem, this patch specifically loads a second font resource (in both the testcase and reference) to provide consistent behavior. Differential Revision: https://phabricator.services.mozilla.com/D116452 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1711479 gecko-commit: 43c6edbfc3dac8013830c4737c051cfc00ae5968 gecko-reviewers: emilio
moz-wptsync-bot
force-pushed
the
gecko/1711479
branch
from
3318f64
to
a86338d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: https://phabricator.services.mozilla.com/D116280
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1711479
gecko-commit: 4e689776fe5d0c2450ee9f01ee6eeb6c1a608f65
gecko-reviewers: emilio