[Gecko Bug 1714513] Use ClipContentDescendants rather than ClipContainingBlockDescendants in nsPageContentFrame::BuildDisplayList. #29303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in nsPageContentFrame::BuildDisplayList. That way we guarantee to clip fixedpos boxes etc. This used to work because this was further up the stack in nsPageFrame rather than nsPageContentFrame: https://hg.mozilla.org/integration/autoland/rev/029a5e8fa8f3179b63a7bf291ea689c4dd642492#l6.262 Differential Revision: https://phabricator.services.mozilla.com/D116857 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1714513 gecko-commit: 884543a0d0aeca41090da50488220ad5101506fe gecko-reviewers: mattwoodrow
wpt-pr-bot
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way we guarantee to clip fixedpos boxes etc. This used to work
because this was further up the stack in nsPageFrame rather than
nsPageContentFrame:
https://hg.mozilla.org/integration/autoland/rev/029a5e8fa8f3179b63a7bf291ea689c4dd642492#l6.262
Differential Revision: https://phabricator.services.mozilla.com/D116857
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1714513
gecko-commit: 884543a0d0aeca41090da50488220ad5101506fe
gecko-reviewers: mattwoodrow