WebXR: fix regression in obtaining pose between targetRay and grip space #29336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 10, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2953960
branch
from
22a58aa
to
8e4c201
Compare
Introduces a change to native origins to be able to distinguish between input-source-derived grip space origin and target ray space origin. Since the native origins of those 2 spaces were identical, the change introduced in https://crrev.com/c/2803481 caused them to be treated as the same space, thus resulting in returning identity pose from XRFrame::getPose() method. Also adds a WPT test that would've caught this regression. Other minor changes: - converted if-elseif-else chain into a switch statement Fixed: 1214497 Change-Id: I66e18b863b2769fce6c8126b5d0ddade99fe9b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2953960 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#892183}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2953960
branch
from
8e4c201
to
37d0a7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a change to native origins to be able to distinguish between
input-source-derived grip space origin and target ray space origin.
Since the native origins of those 2 spaces were identical, the change
introduced in https://crrev.com/c/2803481 caused them to be treated as
the same space, thus resulting in returning identity pose from
XRFrame::getPose() method.
Also adds a WPT test that would've caught this regression.
Other minor changes:
Fixed: 1214497
Change-Id: I66e18b863b2769fce6c8126b5d0ddade99fe9b25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2953960
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892183}