Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9348, 4d74e5: don't try to sell shares of spectators #9349

Merged
merged 1 commit into from Jun 10, 2021

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jun 10, 2021

Closes #9348

Motivation / Problem

Game does boom. I made game go boom. I fix. Me happy.

Description

"new_owner" can be INVALID_OWNER, and as INVALID_OWNER ==
COMPANY_SPECTATORS, we could end up trying to sell shares of
nobody.

while at it, also renamed the last COMPANY_SPECATORS to INVALID_OWNER when talking about shares.
Spectators don't have shares after all.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

michicc
michicc previously approved these changes Jun 10, 2021
@James103
Copy link
Contributor

The actual commit link in the commit title should be 4d74e51 (at least 7 characters), not 4d74e5 (6 characters), so that GitHub generates the proper link to the commit.

"new_owner" can be INVALID_OWNER, and as INVALID_OWNER ==
COMPANY_SPECTATORS, we could end up trying to sell shares of
nobody.
@TrueBrain
Copy link
Member Author

TrueBrain commented Jun 10, 2021

The actual commit link in the commit title should be 4d74e51 (at least 7 characters), not 4d74e5 (6 characters), so that GitHub generates the proper link to the commit.

Your wish is my command :) Tnx @James103 :) I always forget the minimum amount :P

@TrueBrain TrueBrain merged commit ef25afd into OpenTTD:master Jun 10, 2021
@TrueBrain TrueBrain deleted the fix-9300 branch June 10, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion failure when removing company
3 participants