New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate IConsolePrint functions and improve some of the messages #9359
Conversation
986d851
to
c40bad9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first commit is ofc a big no-no, so if anyone during bisecting happens to go back to it, they can get some weird prints, I guess .. but from what I could tell, only in a handful of places, so you have to be really unlucky :P
There also really isn't another way to get where you wanted to go, so I think it is worth doing it like this :)
c40bad9
to
f6afef6
Compare
If a command cannot be executed for whatever reason, it makes no sense to call it a warning. Something has been done wrong. Also make writing of these error message consistent while changing their "type".
Always start with a capital, do not add "ERROR: " in front of it.
Both did not support format parameters, so in many places IConsolePrint(CC_ERROR, "message") was used with a style different from what IConsoleError would do.
…ake them more uniform) and convert to fmt
Also make some strings more consistent with the rest of the console strings.
…messages more uniform
f6afef6
to
9117efb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure this is an improvement :) Other nitpicks can be dealt with another time :) Tnx a bunch for this!
Motivation / Problem
Where to start?
Description
IConsoleWarning(
in lieu ofIConsolePrint(CC_WARNING,
.IConsoleError(
in lieu ofIConsolePrint(CC_ERROR,
.IConsoleHelp(
in lieu ofIConsolePrint(CC_HELP,
.CC_HELP
to distinguish betweenCC_HELP
andCC_WARNING
.Feel free to propose other improvements to strings printed to the in-game console.
If this approach is taken over adding formatting functionality to IConsoleError/Warning, then this closes #8853 and closes #8894.
Limitations
None I think, unless someone did matching on colors of strings, or was actually parsing the strings... as then those might now be broken in some cases.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.