Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report - tar loader ignores empty files. An AI that requires such file fails to start #9358

Closed
SamuXarick opened this issue Jun 12, 2021 · 1 comment
Closed

Bug Report - tar loader ignores empty files. An AI that requires such file fails to start #9358

SamuXarick opened this issue Jun 12, 2021 · 1 comment

Comments

@SamuXarick
Copy link
Contributor

Version of OpenTTD

OpenTTD 1.11.2 and Windows 10

Expected result

.tar loader shouldn't ignore empty files.

Actual result

.tar loader ignores an empty file which is required file for the AI to start without erroring out.

Steps to reproduce

The AI named Mungo, version 5 has an empty file, but it's required for the AI to start.
See conversation https://webster.openttdcoop.org/index.php?channel=openttd&date=1623369600#1623423363
@SamuXarick SamuXarick changed the title Bug Report Bug Report - tar loader ignores empty files. An AI that requires such file fails to start Jun 12, 2021
@glx22
Copy link
Contributor

glx22 commented Jun 13, 2021

Based on fileio.cpp history I think

OpenTTD/src/fileio.cpp

Line 545 in 7d79180

if (skip == 0) break;
can be removed. This check was used to detect folders or special stuff before we actually check entry type.

SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jun 13, 2021
@SamuXarick
Fix OpenTTD#9358: TarScanner no longer ignores empty files
f8823a1
@SamuXarick SamuXarick mentioned this issue Jun 13, 2021
Merged
@glx22 glx22 closed this as completed in 1e6a216 Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glx22 @SamuXarick