bind-gen: Enable the new IDL dictionary implementations #29325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 10, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2928684
branch
7 times, most recently
from
23ca724
to
3a8bc1e
Compare
Enables the new IDL dictionary implementations. The APIs are compatible and no major difference, but there are minor differences between the old and new IDL dictionary implementations: 1. Exact distinction between "missing" and IDL null. (dict->foo() is invalid when !dict->hasFoo().) 2. Use the new IDL unions and the new IDL enumerations as member types of the IDL dictionaries. 3. Move support for (Heap)Vector members. The pinpoint result: https://pinpoint-dot-chromeperf.appspot.com/job/1484ae38320000 bind-gen: switch Bug: 839389 Change-Id: I5fddb608d9a43685963410861955bbd63162935b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2928684 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#891914}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2928684
branch
from
3a8bc1e
to
239bd1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the new IDL dictionary implementations.
The APIs are compatible and no major difference, but there are
minor differences between the old and new IDL dictionary
implementations:
(dict->foo() is invalid when !dict->hasFoo().)
member types of the IDL dictionaries.
The pinpoint result:
https://pinpoint-dot-chromeperf.appspot.com/job/1484ae38320000
bind-gen: switch
Bug: 839389
Change-Id: I5fddb608d9a43685963410861955bbd63162935b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2928684
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#891914}