[Gecko Bug 1681958] Use eReplacedSizing to assert replaced elements for aspect-ratio. #29354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems `eReplacedSizing` is much closer to the definition of replaced elements (defined in [1]), and we override ComputeSize() for those frames which are set eReplacedSizing or inline/table frames. Perhaps we have to update the comments for the frame type bits later. [1] https://html.spec.whatwg.org/multipage/rendering.html#replaced-elements Differential Revision: https://phabricator.services.mozilla.com/D117372 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1681958 gecko-commit: 738bc12bd497cbb828435bbf761c5820c5cb8ffc gecko-reviewers: TYLin
wpt-pr-bot
approved these changes
Jun 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems
eReplacedSizingis much closer to the definition of replacedelements (defined in [1]), and we override ComputeSize() for those
frames which are set eReplacedSizing or inline/table frames.
Perhaps we have to update the comments for the frame type bits later.
[1] https://html.spec.whatwg.org/multipage/rendering.html#replaced-elements
Differential Revision: https://phabricator.services.mozilla.com/D117372
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1681958
gecko-commit: 738bc12bd497cbb828435bbf761c5820c5cb8ffc
gecko-reviewers: TYLin