Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: compatible NewGRFs in crash-log reported wrong md5 #9340

Merged
merged 1 commit into from Jun 8, 2021

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

That moment a crash-report tells you it was missing a GRF + MD5 which you really have on disk. "I don't understand", you say. You check, and check, and check again.

After 15 minutes you start to doubt yourself .. but you realise: this is OpenTTD, better check the source.

Yes.

It was lying to us.

Description

The text suggests it reports the original md5, but it does in fact
report the replaced md5. Now it reports both.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

The text suggests it reports the original md5, but it does in fact
report the replaced md5. Now it reports both.
@TrueBrain TrueBrain merged commit f997eb6 into OpenTTD:master Jun 8, 2021
@TrueBrain TrueBrain deleted the dont-lie-to-me branch June 8, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants